Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][ADD] hr_timesheet_begin_end_no_end #694

Draft
wants to merge 4 commits into
base: 12.0
Choose a base branch
from

Conversation

carmenbianca
Copy link
Member

Backport of #691

Depends on #693

Internal task: T12630

Timesheet lines are characterised by having a project.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
The separation of checks into separate methods is needed because I want
to disable one check in another module. This makes the module more
extensible.

The unit_amount_from_start_stop method also makes the module more
extensible.

I have also moved the onchange to the top of the file, according to the
OCA contribution guidelines.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca carmenbianca force-pushed the 12.0-backport-begin_end_no_end branch 2 times, most recently from e206fca to 95f1331 Compare July 4, 2024 09:38
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same cosmetic remark as #691, otherwise lgtm!

@carmenbianca carmenbianca force-pushed the 12.0-backport-begin_end_no_end branch from 95f1331 to 2b56d05 Compare September 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants